netdev - Re: [PATCH net] net: axienet: fix a signedness bug in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190926132458.GC20927@lunn.ch>
Date:   Thu, 26 Sep 2019 15:24:58 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     "Alvaro G. M" <alvaro.gamez@...ent.com>,
        Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>,
        "David S. Miller" <davem@...emloft.net>,
        Michal Simek <michal.simek@...inx.com>,
        Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] net: axienet: fix a signedness bug in probe

> The get_phy_mode() function seem like they lend themselves to creating
> these bugs.  The ->phy_mode variables tend to be declared in the driver
> so it would require quite a few patches to make them all int and I'm not
> sure that's more beautiful.  Andrew Lunn's idea to update the API would
> probably be a good idea.

Hi Dan

I started on it. Once net-next has opened, and 0-day has compile
tested my changes, i will post the code for review.

       Andrew