netdev - Re: [PATCH net] net: stmmac: dwmac-meson8b: Fix signedness bug in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190927.101548.1428184970448877652.davem@davemloft.net>
Date:   Fri, 27 Sep 2019 10:15:48 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     peppe.cavallaro@...com, martin.blumenstingl@...glemail.com,
        alexandre.torgue@...com, joabreu@...opsys.com,
        khilman@...libre.com, mcoquelin.stm32@...il.com,
        netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] net: stmmac: dwmac-meson8b: Fix signedness bug in
 probe

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Wed, 25 Sep 2019 13:58:22 +0300

> The "dwmac->phy_mode" is an enum and in this context GCC treats it as
> an unsigned int so the error handling is never triggered.
> 
> Fixes: 566e82516253 ("net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.