netdev - Re: [PATCH net] net: ethernet: stmmac: Fix signedness bug in ipq806x_gmac_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190927.102206.1720435175604577653.davem@davemloft.net>
Date:   Fri, 27 Sep 2019 10:22:06 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     peppe.cavallaro@...com, mathieu@...eaurora.org,
        alexandre.torgue@...com, joabreu@...opsys.com,
        mcoquelin.stm32@...il.com, netdev@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] net: ethernet: stmmac: Fix signedness bug in
 ipq806x_gmac_of_parse()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Wed, 25 Sep 2019 14:05:54 +0300

> The "gmac->phy_mode" variable is an enum and in this context GCC will
> treat it as an unsigned int so the error handling will never be
> triggered.
> 
> Fixes: b1c17215d718 ("stmmac: add ipq806x glue layer")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.