netdev - Re: [PATCH net] net: dsa: qca8k: Fix port enable for CPU port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190927.103207.629278236080536516.davem@davemloft.net>
Date:   Fri, 27 Sep 2019 10:32:07 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     netdev@...r.kernel.org, vivien.didelot@...il.com,
        michal.vokac@...ft.com
Subject: Re: [PATCH net] net: dsa: qca8k: Fix port enable for CPU port

From: Andrew Lunn <andrew@...n.ch>
Date: Wed, 25 Sep 2019 02:47:07 +0200

> The CPU port does not have a PHY connected to it. So calling
> phy_support_asym_pause() results in an Opps. As with other DSA
> drivers, add a guard that the port is a user port.
> 
> Reported-by: Michal Vokáč <michal.vokac@...ft.com>
> Fixes: 0394a63acfe2 ("net: dsa: enable and disable all ports")
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Applied.