netdev - Re: [PATCH net 0/3] tcp: provide correct skb->priority

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190927.120533.464156831739223782.davem@davemloft.net>
Date:   Fri, 27 Sep 2019 12:05:33 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net 0/3] tcp: provide correct skb->priority

From: Eric Dumazet <edumazet@...gle.com>
Date: Tue, 24 Sep 2019 08:01:13 -0700

> SO_PRIORITY socket option requests TCP egress packets
> to contain a user provided value.
> 
> TCP manages to send most packets with the requested values,
> notably for TCP_ESTABLISHED state, but fails to do so for
> few packets.
> 
> These packets are control packets sent on behalf
> of SYN_RECV or TIME_WAIT states.
> 
> Note that to test this with packetdrill, it is a bit
> of a hassle, since packetdrill can not verify priority
> of egress packets, other than indirect observations,
> using for example sch_prio on its tunnel device.
> 
> The bad skb priorities cause problems for GCP,
> as this field is one of the keys used in routing.

Series applied, thanks Eric.