lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Sep 2019 10:19:32 -0700 From: Vinicius Costa Gomes <vinicius.gomes@...el.com> To: Vladimir Oltean <olteanv@...il.com>, davem@...emloft.net Cc: jhs@...atatu.com, xiyou.wangcong@...il.com, netdev@...r.kernel.org, Vladimir Oltean <olteanv@...il.com> Subject: Re: [PATCH v2 net] net: sched: taprio: Fix potential integer overflow in taprio_set_picos_per_byte Vladimir Oltean <olteanv@...il.com> writes: > The speed divisor is used in a context expecting an s64, but it is > evaluated using 32-bit arithmetic. > > To avoid that happening, instead of multiplying by 1,000,000 in the > first place, simplify the fraction and do a standard 32 bit division > instead. > > Fixes: f04b514c0ce2 ("taprio: Set default link speed to 10 Mbps in taprio_set_picos_per_byte") > Reported-by: Gustavo A. R. Silva <gustavo@...eddedor.com> > Suggested-by: Eric Dumazet <eric.dumazet@...il.com> > Signed-off-by: Vladimir Oltean <olteanv@...il.com> > --- Acked-by: Vinicius Costa Gomes <vinicius.gomes@...el.com>
Powered by blists - more mailing lists