netdev - Re: [PATCH net] net: dsa: qca8k: Use up to 7 ports for all operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190930.110651.1802452095339417928.davem@davemloft.net>
Date:   Mon, 30 Sep 2019 11:06:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     michal.vokac@...ft.com
Cc:     andrew@...n.ch, netdev@...r.kernel.org, vivien.didelot@...il.com,
        linux-kernel@...r.kernel.org, f.fainelli@...il.com,
        hkallweit1@...il.com
Subject: Re: [PATCH net] net: dsa: qca8k: Use up to 7 ports for all
 operations

From: Michal Vokáč <michal.vokac@...ft.com>
Date: Thu, 26 Sep 2019 10:59:17 +0200

> The QCA8K family supports up to 7 ports. So use the existing
> QCA8K_NUM_PORTS define to allocate the switch structure and limit all
> operations with the switch ports.
> 
> This was not an issue until commit 0394a63acfe2 ("net: dsa: enable and
> disable all ports") disabled all unused ports. Since the unused ports 7-11
> are outside of the correct register range on this switch some registers
> were rewritten with invalid content.
> 
> Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family")
> Fixes: a0c02161ecfc ("net: dsa: variable number of ports")
> Fixes: 0394a63acfe2 ("net: dsa: enable and disable all ports")
> Signed-off-by: Michal Vokáč <michal.vokac@...ft.com>

Applied.