netdev - Re: [PATCH] net: dsa: rtl8366rb: add missing of_node_put after calling of_get_child_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdY-SnPjocWzoujah6c=Tnj8G7XqBgULXYNwnt6FvED37g@mail.gmail.com>
Date:   Mon, 30 Sep 2019 23:56:50 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Wen Yang <wenyang@...ux.alibaba.com>
Cc:     xlpang@...ux.alibaba.com, zhiche.yy@...baba-inc.com,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: dsa: rtl8366rb: add missing of_node_put after
 calling of_get_child_by_name

On Sun, Sep 29, 2019 at 9:01 AM Wen Yang <wenyang@...ux.alibaba.com> wrote:

It's nice to see some Alibaba kernel contributions!

> of_node_put needs to be called when the device node which is got
> from of_get_child_by_name finished using.
> irq_domain_add_linear() also calls of_node_get() to increase refcount,
> so irq_domain will not be affected when it is released.
>
> fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")
> Signed-off-by: Wen Yang <wenyang@...ux.alibaba.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Vivien Didelot <vivien.didelot@...il.com>
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: netdev@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij