netdev - Re: [PATCH bpf v5] libbpf: handle symbol versioning properly for libbpf.a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b16a18c0-bd16-4b2f-1ee6-f7bc6477da44@fb.com>
Date:   Mon, 30 Sep 2019 22:27:53 +0000
From:   Alexei Starovoitov <ast@...com>
To:     Yonghong Song <yhs@...com>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <Kernel-team@...com>,
        Kevin Laatz <kevin.laatz@...el.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Andrii Nakryiko <andriin@...com>
Subject: Re: [PATCH bpf v5] libbpf: handle symbol versioning properly for
 libbpf.a

On 9/30/19 2:02 PM, Yonghong Song wrote:
> Fixes: 10d30e301732 ("libbpf: add flags to umem config")
> Cc: Kevin Laatz<kevin.laatz@...el.com>
> Cc: Arnaldo Carvalho de Melo<acme@...hat.com>
> Cc: Andrii Nakryiko<andriin@...com>
> Acked-by: Andrii Nakryiko<andriin@...com>
> Signed-off-by: Yonghong Song<yhs@...com>
> ---
>   tools/lib/bpf/Makefile          | 27 ++++++++++++++++++---------
>   tools/lib/bpf/libbpf_internal.h | 16 ++++++++++++++++
>   tools/lib/bpf/xsk.c             |  4 ++--
>   3 files changed, 36 insertions(+), 11 deletions(-)
> 
> ChangeLog:
>    v4 -> v5:
>       - Think twice. Using weak symbol for the libbpf.a API function
>         xsk_umem__create() is not right. Let us make it as a non-weak
>         global symbol so users cannot accidentally redefine it.

Applied. Thanks