netdev - Re: [PATCH v2 net] devlink: Fix error handling in param and info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190930065010.GA2211@nanopsycho>
Date:   Mon, 30 Sep 2019 08:50:10 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vasundhara Volam <vasundhara-v.volam@...adcom.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        Andrew Lunn <andrew@...n.ch>, Jiri Pirko <jiri@...lanox.com>,
        Michael Chan <michael.chan@...adcom.com>
Subject: Re: [PATCH v2 net] devlink: Fix error handling in param and info_get
 dumpit cb

Mon, Sep 30, 2019 at 08:22:21AM CEST, vasundhara-v.volam@...adcom.com wrote:
>If any of the param or info_get op returns error, dumpit cb is
>skipping to dump remaining params or info_get ops for all the
>drivers.
>
>Fix to not return if any of the param/info_get op returns error
>as not supported and continue to dump remaining information.
>
>v2: Modify the patch to return error, except for params/info_get
>op that return -EOPNOTSUPP as suggested by Andrew Lunn. Also, modify
>commit message to reflect the same.
>
>Cc: Andrew Lunn <andrew@...n.ch>
>Cc: Jiri Pirko <jiri@...lanox.com>
>Cc: Michael Chan <michael.chan@...adcom.com>
>Signed-off-by: Vasundhara Volam <vasundhara-v.volam@...adcom.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>