netdev - Re: [RFC 3/4] net: mvneta: add basic XDP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191001114753.GB30888@localhost.localdomain>
Date:   Tue, 1 Oct 2019 13:47:53 +0200
From:   Lorenzo Bianconi <lorenzo@...nel.org>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     Toke Høiland-Jørgensen <toke@...hat.com>,
        Maciej Fijalkowski <maciejromanfijalkowski@...il.com>,
        netdev@...r.kernel.org, thomas.petazzoni@...tlin.com,
        ilias.apalodimas@...aro.org, mcroce@...hat.com
Subject: Re: [RFC 3/4] net: mvneta: add basic XDP support

> On Tue, 01 Oct 2019 13:06:36 +0200
> Toke Høiland-Jørgensen <toke@...hat.com> wrote:
> 
> > Maciej Fijalkowski <maciejromanfijalkowski@...il.com> writes:
> > 
> > > On Tue,  1 Oct 2019 11:24:43 +0200
> > > Lorenzo Bianconi <lorenzo@...nel.org> wrote:
> > >  
> > >> Add basic XDP support to mvneta driver for devices that rely on software
> > >> buffer management. Currently supported verdicts are:
> > >> - XDP_DROP
> > >> - XDP_PASS
> > >> - XDP_REDIRECT  
> > >
> > > You're supporting XDP_ABORTED as well :P any plans for XDP_TX?  
> > 
> > Wait, if you are supporting REDIRECT but not TX, that means redirect
> > only works to other, non-mvneta, devices, right? Maybe that should be
> > made clear in the commit message :)
> 
> If you implemented XDP_REDIRECT, then it should be trivial to implement
> XDP_TX, as you can just convert the xdp_buff to xdp_frame and call your
> ndo_xdp_xmit function directly (and do the tail-flush).
> 
> Or maybe you are missing a ndo_xdp_xmit function (as Toke indirectly
> points out).

Hi Jesper and Toke,

my plan is to add XDP_TX before posting a formal series (I am working on it).
I shared this RFC series to get some comments and share the current status.

Regards,
Lorenzo

> 
> -- 
> Best regards,
>   Jesper Dangaard Brouer
>   MSc.CS, Principal Kernel Engineer at Red Hat
>   LinkedIn: http://www.linkedin.com/in/brouer

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)