netdev - Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Oct 2019 16:16:05 +0200
From:   Björn Töpel <bjorn.topel@...il.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Björn Töpel <bjorn.topel@...el.com>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig

On Tue, 1 Oct 2019 at 14:33, Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
>
> Hi Bjorn
>
> On Tue, Oct 1, 2019 at 7:14 PM Björn Töpel <bjorn.topel@...il.com> wrote:
> >
[...]
> >  subdir-$(CONFIG_SAMPLE_VFS)            += vfs
> > +subdir-$(CONFIG_SAMPLE_BPF)            += bpf
>
>
> Please keep samples/Makefile sorted alphabetically.
>

Thank you, I'll address that in the v2!

>
>
>
> I am not checking samples/bpf/Makefile, but
> allmodconfig no longer compiles for me.
>
>
>
> samples/bpf/Makefile:209: WARNING: Detected possible issues with include path.
> samples/bpf/Makefile:210: WARNING: Please install kernel headers
> locally (make headers_install).
> error: unable to create target: 'No available targets are compatible
> with triple "bpf"'
> 1 error generated.
> readelf: Error: './llvm_btf_verify.o': No such file
> *** ERROR: LLVM (llc) does not support 'bpf' target
>    NOTICE: LLVM version >= 3.7.1 required
>

Yes, the BPF samples require clang/LLVM with BPF support to build. Any
suggestion on a good way to address this (missing tools), better than
the warning above? After the commit 394053f4a4b3 ("kbuild: make single
targets work more correctly"), it's no longer possible to build
samples/bpf without support in the samples/Makefile.


Thanks,
Björn

> --
> Best Regards
> Masahiro Yamada