lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191001075928.26f1dd43@hermes.lan>
Date:   Tue, 1 Oct 2019 07:59:28 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>
Cc:     dsahern@...il.com, netdev@...r.kernel.org, ivecera@...hat.com,
        nikolay@...ulusnetworks.com
Subject: Re: [PATCH iproute2 net-next v3 1/2] bridge: fdb get support

On Mon, 30 Sep 2019 21:52:22 -0700
Roopa Prabhu <roopa@...ulusnetworks.com> wrote:

> +
> +	if (sscanf(addr, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx",
> +		   abuf, abuf+1, abuf+2,
> +		   abuf+3, abuf+4, abuf+5) != 6) {
> +		fprintf(stderr, "Invalid mac address %s\n", addr);
> +		return -1;
> +	}

You could use ether_aton here if that would help.
Not required, but ether_ntoa already used in iplink_bridge.c

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ