netdev - Re: [PATCH iproute2(-next) v2 1/1] ip: fix ip route show json output for multipath nexthops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba5f6b14-1740-b9ba-c100-5272765fbef4@gmail.com>
Date:   Tue, 1 Oct 2019 09:14:28 -0600
From:   David Ahern <dsahern@...il.com>
To:     Julien Fortin <julien@...ulusnetworks.com>, netdev@...r.kernel.org
Cc:     roopa@...ulusnetworks.com
Subject: Re: [PATCH iproute2(-next) v2 1/1] ip: fix ip route show json output
 for multipath nexthops

On 9/26/19 9:29 AM, Julien Fortin wrote:
> From: Julien Fortin <julien@...ulusnetworks.com>
> 
> print_rta_multipath doesn't support JSON output:
> 
> {
>     "dst":"27.0.0.13",
>     "protocol":"bgp",
>     "metric":20,
>     "flags":[],
>     "gateway":"169.254.0.1"dev uplink-1 weight 1 ,
>     "flags":["onlink"],
>     "gateway":"169.254.0.1"dev uplink-2 weight 1 ,
>     "flags":["onlink"]
> },
> 
> since RTA_MULTIPATH has nested objects we should print them
> in a json array.
> 
> With the path we have the following output:
> 
> {
>     "flags": [],
>     "dst": "36.0.0.13",
>     "protocol": "bgp",
>     "metric": 20,
>     "nexthops": [
>         {
>             "weight": 1,
>             "flags": [
>                 "onlink"
>             ],
>             "gateway": "169.254.0.1",
>             "dev": "uplink-1"
>         },
>         {
>             "weight": 1,
>             "flags": [
>                 "onlink"
>             ],
>             "gateway": "169.254.0.1",
>             "dev": "uplink-2"
>         }
>     ]
> }
> 
> Fixes: 663c3cb23103f4 ("iproute: implement JSON and color output")
> 
> Signed-off-by: Julien Fortin <julien@...ulusnetworks.com>
> ---
>  ip/iproute.c | 46 ++++++++++++++++++++++++++++------------------
>  1 file changed, 28 insertions(+), 18 deletions(-)
> 

applied to iproute2-next. Thanks

Stephen: I see only 1 place (mdb) that prints devices with color, so
that can be done across all of the commands by a follow up.