netdev - Re: [PATCH net] netfilter: drop bridge nf reset from nf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191001164326.ifgirwawm52zcr7b@salvia>
Date:   Tue, 1 Oct 2019 18:43:26 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Florian Westphal <fw@...len.de>
Cc:     netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
        edumazet@...gle.com
Subject: Re: [PATCH net] netfilter: drop bridge nf reset from nf_reset

On Sun, Sep 29, 2019 at 08:54:03PM +0200, Florian Westphal wrote:
> commit 174e23810cd31
> ("sk_buff: drop all skb extensions on free and skb scrubbing") made napi
> recycle always drop skb extensions.  The additional skb_ext_del() that is
> performed via nf_reset on napi skb recycle is not needed anymore.
> 
> Most nf_reset() calls in the stack are there so queued skb won't block
> 'rmmod nf_conntrack' indefinitely.
> 
> This removes the skb_ext_del from nf_reset, and renames it to a more
> fitting nf_reset_ct().
> 
> In a few selected places, add a call to skb_ext_reset to make sure that
> no active extensions remain.
> 
> I am submitting this for "net", because we're still early in the release
> cycle.  The patch applies to net-next too, but I think the rename causes
> needless divergence between those trees.

Applied, thanks.