netdev - Re: [PATCH net-next 0/9] optimize openvswitch flow looking up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12EAB90C-827E-4BC5-8CED-08DA510CF566@redhat.com>
Date:   Tue, 01 Oct 2019 10:53:02 +0200
From:   "Eelco Chaudron" <echaudro@...hat.com>
To:     xiangxia.m.yue@...il.com, "ovs dev" <dev@...nvswitch.org>
Cc:     gvrose8192@...il.com, pshelar@....org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/9] optimize openvswitch flow looking up

Interesting performance gain, copied in the OVS development mailing 
list.

//Eelco

On 29 Sep 2019, at 19:09, xiangxia.m.yue@...il.com wrote:

> From: Tonghao Zhang <xiangxia.m.yue@...il.com>
>
> This series patch optimize openvswitch.
>
> Patch 1, 2, 4: Port Pravin B Shelar patches to
> linux upstream with little changes.
>
> Patch 5, 6, 7: Optimize the flow looking up and
> simplify the flow hash.
>
> Patch 8: is a bugfix.
>
> The performance test is on Intel Xeon E5-2630 v4.
> The test topology is show as below:
>
> +-----------------------------------+
> |   +---------------------------+   |
> |   | eth0   ovs-switch    eth1 |   | Host0
> |   +---------------------------+   |
> +-----------------------------------+
>       ^                       |
>       |                       |
>       |                       |
>       |                       |
>       |                       v
> +-----+----+             +----+-----+
> | netperf  | Host1       | netserver| Host2
> +----------+             +----------+
>
> We use netperf send the 64B frame, and insert 255+ flow-mask:
> $ ovs-dpctl add-flow ovs-switch 
> "in_port(1),eth(dst=00:01:00:00:00:00/ff:ff:ff:ff:ff:01),eth_type(0x0800),ipv4(frag=no)" 
> 2
> ...
> $ ovs-dpctl add-flow ovs-switch 
> "in_port(1),eth(dst=00:ff:00:00:00:00/ff:ff:ff:ff:ff:ff),eth_type(0x0800),ipv4(frag=no)" 
> 2
> $ netperf -t UDP_STREAM -H 2.2.2.200 -l 40 -- -m 18
>
> * Without series patch, throughput 8.28Mbps
> * With series patch, throughput 46.05Mbps
>
> Tonghao Zhang (9):
>   net: openvswitch: add flow-mask cache for performance
>   net: openvswitch: convert mask list in mask array
>   net: openvswitch: shrink the mask array if necessary
>   net: openvswitch: optimize flow mask cache hash collision
>   net: openvswitch: optimize flow-mask looking up
>   net: openvswitch: simplify the flow_hash
>   net: openvswitch: add likely in flow_lookup
>   net: openvswitch: fix possible memleak on destroy flow table
>   net: openvswitch: simplify the ovs_dp_cmd_new
>
>  net/openvswitch/datapath.c   |  63 +++++----
>  net/openvswitch/flow.h       |   1 -
>  net/openvswitch/flow_table.c | 318 
> +++++++++++++++++++++++++++++++++++++------
>  net/openvswitch/flow_table.h |  19 ++-
>  4 files changed, 330 insertions(+), 71 deletions(-)
>
> -- 
> 1.8.3.1