netdev - Re: [PATCH net] net: dsa: sja1105: Prevent leaking memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190930.172551.1670850073296784762.davem@davemloft.net>
Date:   Mon, 30 Sep 2019 17:25:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, vivien.didelot@...il.com,
        netdev@...r.kernel.org, navid.emamdoost@...il.com
Subject: Re: [PATCH net] net: dsa: sja1105: Prevent leaking memory

From: Vladimir Oltean <olteanv@...il.com>
Date: Sun, 29 Sep 2019 01:43:39 +0300

> From: Navid Emamdoost <navid.emamdoost@...il.com>
> 
> In sja1105_static_config_upload, in two cases memory is leaked: when
> static_config_buf_prepare_for_upload fails and when sja1105_inhibit_tx
> fails. In both cases config_buf should be released.
> 
> Fixes: 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch")
> Fixes: 1a4c69406cc1 ("net: dsa: sja1105: Prevent PHY jabbering during switch reset")
> Signed-off-by: Navid Emamdoost <navid.emamdoost@...il.com>
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>

Applied and queued up for -stable.