netdev - Re: [RFC 3/4] net: mvneta: add basic XDP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875zl8vide.fsf@toke.dk>
Date:   Tue, 01 Oct 2019 13:02:21 +0200
From:   Toke Høiland-Jørgensen <toke@...hat.com>
To:     Matteo Croce <mcroce@...hat.com>,
        Lorenzo Bianconi <lorenzo@...nel.org>
Cc:     netdev@...r.kernel.org, thomas.petazzoni@...tlin.com,
        ilias.apalodimas@...aro.org, brouer@...hat.com
Subject: Re: [RFC 3/4] net: mvneta: add basic XDP support

Matteo Croce <mcroce@...hat.com> writes:

> On Tue,  1 Oct 2019 11:24:43 +0200
> Lorenzo Bianconi <lorenzo@...nel.org> wrote:
>> +static int mvneta_xdp_setup(struct net_device *dev, struct bpf_prog
>> *prog,
>> +			    struct netlink_ext_ack *extack)
>> +{
>> +	struct mvneta_port *pp = netdev_priv(dev);
>> +	struct bpf_prog *old_prog;
>> +
>> +	if (prog && dev->mtu > MVNETA_MAX_RX_BUF_SIZE) {
>> +		NL_SET_ERR_MSG_MOD(extack, "Jumbo frames not
>> supported on XDP");
>> +		return -EOPNOTSUPP;
>
> -ENOTSUPP maybe?

No, ENOTSUPP is NFS-specific, and defined in a non-UAPI header; the
correct one to use is EOPNOTSUPP :)

-Toke