netdev - Re: [PATCH net] mlx5: avoid 64-bit division in dr_icm_pool_mr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191002.110841.1635125794151710562.davem@davemloft.net>
Date:   Wed, 02 Oct 2019 11:08:41 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     valex@...lanox.com
Cc:     mkubecek@...e.cz, saeedm@...lanox.com, leon@...nel.org,
        bp@...en8.de, stephen@...workplumber.org, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] mlx5: avoid 64-bit division in
 dr_icm_pool_mr_create()

From: Alex Vesker <valex@...lanox.com>
Date: Wed, 2 Oct 2019 14:58:44 +0000

> On 10/2/2019 3:12 PM, Michal Kubecek wrote:
>> Recently added code introduces 64-bit division in dr_icm_pool_mr_create()
>> so that build on 32-bit architectures fails with
>>
>>    ERROR: "__umoddi3" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko] undefined!
>>
>> As the divisor is always a power of 2, we can use bitwise operation
>> instead.
>>
>> Fixes: 29cf8febd185 ("net/mlx5: DR, ICM pool memory allocator")
>> Reported-by: Borislav Petkov <bp@...en8.de>
>> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>
 ...
> Align diff is power of 2,  looks good to me.
> Thanks for fixing it Michal.

I'll just apply this directly, thanks everyone.