netdev - Re: [PATCH iproute2 net-next v3 1/2] bridge: fdb get support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJieiUhs1Hr-LxEhO7Keary3MwPWtWTwwhZ=1+5kiawfxRU4Pw@mail.gmail.com>
Date:   Wed, 2 Oct 2019 09:07:17 -0700
From:   Roopa Prabhu <roopa@...ulusnetworks.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     David Ahern <dsahern@...il.com>, netdev <netdev@...r.kernel.org>,
        Ivan Vecera <ivecera@...hat.com>,
        Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Subject: Re: [PATCH iproute2 net-next v3 1/2] bridge: fdb get support

On Tue, Oct 1, 2019 at 7:59 AM Stephen Hemminger
<stephen@...workplumber.org> wrote:
>
> On Mon, 30 Sep 2019 21:52:22 -0700
> Roopa Prabhu <roopa@...ulusnetworks.com> wrote:
>
> > +
> > +     if (sscanf(addr, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx",
> > +                abuf, abuf+1, abuf+2,
> > +                abuf+3, abuf+4, abuf+5) != 6) {
> > +             fprintf(stderr, "Invalid mac address %s\n", addr);
> > +             return -1;
> > +     }
>
> You could use ether_aton here if that would help.
> Not required, but ether_ntoa already used in iplink_bridge.

ok ack, i will take a look. I think i picked this up from
bridge/fdb.c:fdb_modify