netdev - Re: [PATCH v2] ar5523: check NULL before memcpy() in ar5523

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191002172208.78D4C6115A@smtp.codeaurora.org>
Date:   Wed,  2 Oct 2019 17:22:08 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Denis Efremov <efremov@...ux.com>
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Denis Efremov <efremov@...ux.com>,
        Pontus Fuchs <pontus.fuchs@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        David Laight <David.Laight@...LAB.COM>, stable@...r.kernel.org
Subject: Re: [PATCH v2] ar5523: check NULL before memcpy() in ar5523_cmd()

Denis Efremov <efremov@...ux.com> wrote:

> memcpy() call with "idata == NULL && ilen == 0" results in undefined
> behavior in ar5523_cmd(). For example, NULL is passed in callchain
> "ar5523_stat_work() -> ar5523_cmd_write() -> ar5523_cmd()". This patch
> adds ilen check before memcpy() call in ar5523_cmd() to prevent an
> undefined behavior.
> 
> Cc: Pontus Fuchs <pontus.fuchs@...il.com>
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: David Laight <David.Laight@...LAB.COM>
> Cc: stable@...r.kernel.org
> Signed-off-by: Denis Efremov <efremov@...ux.com>
> Signed-off-by: Kalle Valo <kvalo@...eaurora.org>

Patch applied to ath-next branch of ath.git, thanks.

315cee426f87 ar5523: check NULL before memcpy() in ar5523_cmd()

-- 
https://patchwork.kernel.org/patch/11167401/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches