netdev - Re: [PATCH net v2 2/2] udp: only do GSO if # of segs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d19e8d2fe1c54ef3c94b40805e8d8d78625557c.camel@intel.com>
Date:   Wed, 2 Oct 2019 21:11:50 +0000
From:   "Duyck, Alexander H" <alexander.h.duyck@...el.com>
To:     "davem@...emloft.net" <davem@...emloft.net>,
        "johunt@...mai.com" <johunt@...mai.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "willemb@...gle.com" <willemb@...gle.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>
Subject: Re: [PATCH net v2 2/2] udp: only do GSO if # of segs > 1

On Wed, 2019-10-02 at 13:29 -0400, Josh Hunt wrote:
> Prior to this change an application sending <= 1MSS worth of data and
> enabling UDP GSO would fail if the system had SW GSO enabled, but the
> same send would succeed if HW GSO offload is enabled. In addition to this
> inconsistency the error in the SW GSO case does not get back to the
> application if sending out of a real device so the user is unaware of this
> failure.
> 
> With this change we only perform GSO if the # of segments is > 1 even
> if the application has enabled segmentation. I've also updated the
> relevant udpgso selftests.
> 
> Fixes: bec1f6f69736 ("udp: generate gso with UDP_SEGMENT")
> Signed-off-by: Josh Hunt <johunt@...mai.com>
> ---
>  net/ipv4/udp.c                       | 11 +++++++----
>  net/ipv6/udp.c                       | 11 +++++++----
>  tools/testing/selftests/net/udpgso.c | 16 ++++------------
>  3 files changed, 18 insertions(+), 20 deletions(-)

Reviewed-by: Alexander Duyck <alexander.h.duyck@...ux.intel.com>