netdev - Re: [PATCH net v2] ipv6: Handle race in addrconf_dad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7bd928cb-1abf-bbae-e1db-505788254e5b@gmail.com>
Date:   Wed, 2 Oct 2019 15:36:47 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     David Ahern <dsahern@...il.com>, David Ahern <dsahern@...nel.org>,
        davem@...emloft.net, jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, rajendra.dendukuri@...adcom.com
Subject: Re: [PATCH net v2] ipv6: Handle race in addrconf_dad_work



On 10/2/19 3:33 PM, David Ahern wrote:
> On 10/2/19 4:21 PM, Eric Dumazet wrote:
>> o syzbot this time, but complete lack of connectivity on some of my test hosts.
>>
>> Incoming IPv6 packets go to ip6_forward() (!!!) and are dropped there.
> 
> what does 'ip -6 addr sh' show when it is in this state? Any idea of the
> order of events?

This might be related to a use of a bonding device, with a mlx4 slave.

"ip -6 addr sh" shows the same output before/after the patch.

lpaa23:~# ip -6 addr sh dev eth0
2: eth0: <BROADCAST,MULTICAST,MASTER,UP,LOWER_UP> mtu 5102 state UP 
    inet6 2607:f8b0:8099:e17::/128 scope global nodad 
       valid_lft forever preferred_lft forever
    inet6 fe80::21a:11ff:fec3:d7f/64 scope link 
       valid_lft forever preferred_lft forever

> 
> I flipped to IF_READY based on addrconf_ifdown and idev checks seeming
> more appropriate.
>