netdev - Re: [PATCH] tcp: add tsval and tsecr to TCP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Oct 2019 16:14:37 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     William Dauchy <wdauchy@...il.com>
Cc:     NETDEV <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] tcp: add tsval and tsecr to TCP_INFO



On 10/2/19 3:54 PM, William Dauchy wrote:
> Hello Eric,
> 
> On Thu, Oct 3, 2019 at 12:33 AM Eric Dumazet <eric.dumazet@...il.com> wrote:
>> On 10/2/19 3:10 PM, William Dauchy wrote:
>> Reporting the last recorded values is really not good,
>> a packet capture will give you all this information in a non
>> racy way.
> 
> Thank you for your quick answer.
> In my use case I use it on a http server where I tag my requests with
> such informations coming from tcp, which later helps to diagnose some
> issues and create some useful metrics to give me a general signal.
> Does it still sound like an invalid use case?

I would rather use a new getsockopt() to fetch this specific data,
instead of making TCP_INFO bigger for everyone :/

ss command can dump millions of sockets in busy hosts, we need to be
careful of TCP_INFO size.