netdev - Re: [PATCH][next] can: fix resource leak of skb on error return paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <720cf73f-8df0-6cee-33bd-41aa8b72dd8d@pengutronix.de>
Date:   Tue, 1 Oct 2019 22:04:10 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Colin King <colin.king@...onical.com>,
        Robin van der Gracht <robin@...tonic.nl>,
        Oleksij Rempel <linux@...pel-privat.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Oliver Hartkopp <socketcan@...tkopp.net>,
        "David S . Miller" <davem@...emloft.net>,
        linux-can@...r.kernel.org, netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] can: fix resource leak of skb on error return paths

On 9/18/19 12:11 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently the error return paths do not free skb and this results
> in a memory leak. Fix this by freeing them before the return.
> 
> Addresses-Coverity: ("Resource leak")
> Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Added to can.

tnx.
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)