netdev - RE: [PATCH] net: stmmac: Read user ID muliple times if needed.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Oct 2019 08:02:02 +0000
From:   Hans Andersson <Hans.Andersson@...LAVISION.SE>
To:     Jose Abreu <Jose.Abreu@...opsys.com>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>
CC:     "peppe.cavallaro@...com" <peppe.cavallaro@...com>,
        "alexandre.torgue@...com" <alexandre.torgue@...com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] net: stmmac: Read user ID muliple times if needed.

We assert / de-assert the reset line, but the CPU is too fast and the IP is still 
in reset when we later try to read user ID / Synopsys ID. Another option would
be to add a delay after we reset.

-----Original Message-----
From: Jose Abreu <Jose.Abreu@...opsys.com> 
Sent: den 2 oktober 2019 09:52
To: Hans Andersson <Hans.Andersson@...LAVISION.SE>; mcoquelin.stm32@...il.com
Cc: peppe.cavallaro@...com; alexandre.torgue@...com; davem@...emloft.net; netdev@...r.kernel.org; linux-stm32@...md-mailman.stormreply.com; linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; Hans Andersson <Hans.Andersson@...LAVISION.SE>
Subject: RE: [PATCH] net: stmmac: Read user ID muliple times if needed.

From: Hans Andersson <haan@...lavision.se>
Date: Oct/02/2019, 08:07:21 (UTC+00:00)

> When we read user ID / Synopsys ID we might still be in reset, so read 
> muliple times if needed.

We shouldn't even try to read it if IP is in reset ... 

---
Thanks,
Jose Miguel Abreu