netdev - Re: [PATCH net] cxgb4: fix out-of-bounds MSI-X info array access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191001.213820.377414760480275548.davem@davemloft.net>
Date:   Tue, 01 Oct 2019 21:38:20 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     vishal@...lsio.com
Cc:     netdev@...r.kernel.org, nirranjan@...lsio.com,
        indranil@...lsio.com, shahjada@...lsio.com
Subject: Re: [PATCH net] cxgb4: fix out-of-bounds MSI-X info array access

From: Vishal Kulkarni <vishal@...lsio.com>
Date: Tue,  1 Oct 2019 04:07:57 +0530

> When fetching free MSI-X vectors for ULDs, check for the
> error code before accessing MSI-X info array. Otherwise,
> an out-of-bounds access is attempted, which results in
> kernel panic.
> 
> Fixes: 94cdb8bb993a ("cxgb4: Add support for dynamic allocation of
> resources for ULD")

Please do not split Fixes: tags onto multiple lines.

> Signed-off-by: Shahjada Abul Husain <shahjada@...lsio.com>
> Signed-off-by: Vishal Kulkarni <vishal@...lsio.com>

This patch adds a new warning:

drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c: In function ‘cxgb4_register_uld’:
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c:179:26: warning: ‘bmap_idx’ may be used uninitialized in this function [-Wmaybe-uninitialized]
    rxq_info->msix_tbl[i] = bmap_idx;
    ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c:141:14: note: ‘bmap_idx’ was declared here
  int i, err, bmap_idx, msi_idx, que_idx = 0;
              ^~~~~~~~