netdev - Re: [PATCH net v2 2/2] udp: only do GSO if # of segs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191003.115004.60330572167098261.davem@davemloft.net>
Date:   Thu, 03 Oct 2019 11:50:04 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     johunt@...mai.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, willemb@...gle.com,
        alexander.h.duyck@...el.com
Subject: Re: [PATCH net v2 2/2] udp: only do GSO if # of segs > 1

From: Josh Hunt <johunt@...mai.com>
Date: Wed,  2 Oct 2019 13:29:23 -0400

> Prior to this change an application sending <= 1MSS worth of data and
> enabling UDP GSO would fail if the system had SW GSO enabled, but the
> same send would succeed if HW GSO offload is enabled. In addition to this
> inconsistency the error in the SW GSO case does not get back to the
> application if sending out of a real device so the user is unaware of this
> failure.
> 
> With this change we only perform GSO if the # of segments is > 1 even
> if the application has enabled segmentation. I've also updated the
> relevant udpgso selftests.
> 
> Fixes: bec1f6f69736 ("udp: generate gso with UDP_SEGMENT")
> Signed-off-by: Josh Hunt <johunt@...mai.com>

Applied and queued up for -stable.