netdev - Re: [PATCH 0/2] net: phy: broadcom: RGMII delays fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d5e4195-c407-2915-de96-3c4b3713ada0@gmail.com>
Date:   Thu, 3 Oct 2019 11:55:40 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        open list <linux-kernel@...r.kernel.org>, hkallweit1@...il.com,
        bcm-kernel-feedback-list@...adcom.com,
        manasa.mudireddy@...adcom.com, ray.jui@...adcom.com,
        olteanv@...il.com, rafal@...ecki.pl
Subject: Re: [PATCH 0/2] net: phy: broadcom: RGMII delays fixes

Hi Andrew,

On 10/3/19 11:51 AM, Andrew Lunn wrote:
> On Thu, Oct 03, 2019 at 11:43:50AM -0700, Florian Fainelli wrote:
>> Hi all,
>>
>> This patch series fixes the BCM54210E RGMII delay configuration which
>> could only have worked in a PHY_INTERFACE_MODE_RGMII configuration.
> 
> Hi Florian
> 
> So any DT blob which incorrectly uses one of the other RGMII modes is
> now going to break, where as before it was ignored.

Potentially yes. There is a precedent with the at803x PHY driver, and
both changes here aim for correcting that mistake. The PHY driver not
looking at phy_interface_t is a bug though. I will have a separate
conversation about solving those problems in a more generic way with you
and Heiner.

Rafal, do you have the platform DTS for which you added BCM54210E
support available somewhere so we can see whether this is going to break?

> 
> Maybe we should let this sit in net-next for a while, before back
> porting, so we get an idea of how many platforms we might be about to
> break?

Fine with me. It solves Ray's and Manasa's customer problem immediately
and they already back ported the first change in the their tree AFAICT.
-- 
Florian