netdev - Re: [PATCH net-next] net: propagate errors correctly in register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191003.123125.1653429259406233251.davem@davemloft.net>
Date:   Thu, 03 Oct 2019 12:31:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, jiri@...lanox.com,
        syzkaller@...glegroups.com
Subject: Re: [PATCH net-next] net: propagate errors correctly in
 register_netdevice()

From: Eric Dumazet <edumazet@...gle.com>
Date: Thu,  3 Oct 2019 08:59:24 -0700

> If netdev_name_node_head_alloc() fails to allocate
> memory, we absolutely want register_netdevice() to return
> -ENOMEM instead of zero :/
> 
> One of the syzbot report looked like :
> 
> general protection fault: 0000 [#1] PREEMPT SMP KASAN
 ...
> Fixes: ff92741270bf ("net: introduce name_node struct to be used in hashlist")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Jiri Pirko <jiri@...lanox.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied.