netdev - Re: [PATCH] openvswitch: Allow attaching helper in later commit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAG1aQh+4Fvorcwq5jUw5dXK2yn+UDQJAmQ4XGKpV7EtUzciA5g@mail.gmail.com>
Date:   Thu, 3 Oct 2019 12:44:35 -0700
From:   Yi-Hung Wei <yihung.wei@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH] openvswitch: Allow attaching helper in later commit

On Thu, Oct 3, 2019 at 8:31 AM David Miller <davem@...emloft.net> wrote:
>
> From: Yi-Hung Wei <yihung.wei@...il.com>
> Date: Mon, 30 Sep 2019 12:39:04 -0700
>
> > -             if ((nf_ct_is_confirmed(ct) ? !cached : info->commit) &&
> > +             if ((nf_ct_is_confirmed(ct) ? !cached | add_helper :
>
> I would suggest using "||" instea of "|" here since you are computing
> a boolean.

Thanks for review.  It makes sense to use "||" rather than "|".  I
will wait a bit to gather more feedback before I send v2.

Thanks,

-Yi-Hung