netdev - Re: [PATCH 0/2] net: phy: broadcom: RGMII delays fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191003201034.GF21875@lunn.ch>
Date:   Thu, 3 Oct 2019 22:10:34 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        netdev <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        open list <linux-kernel@...r.kernel.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        bcm-kernel-feedback-list@...adcom.com,
        manasa.mudireddy@...adcom.com, ray.jui@...adcom.com,
        rafal@...ecki.pl
Subject: Re: [PATCH 0/2] net: phy: broadcom: RGMII delays fixes

On Thu, Oct 03, 2019 at 10:54:26PM +0300, Vladimir Oltean wrote:
> Hi Andrew,
> 
> On Thu, 3 Oct 2019 at 22:06, Andrew Lunn <andrew@...n.ch> wrote:
> >
> > On Thu, Oct 03, 2019 at 11:55:40AM -0700, Florian Fainelli wrote:
> > > Hi Andrew,
> > >
> > > On 10/3/19 11:51 AM, Andrew Lunn wrote:
> > > > On Thu, Oct 03, 2019 at 11:43:50AM -0700, Florian Fainelli wrote:
> > > >> Hi all,
> > > >>
> > > >> This patch series fixes the BCM54210E RGMII delay configuration which
> > > >> could only have worked in a PHY_INTERFACE_MODE_RGMII configuration.
> > > >
> > > > Hi Florian
> > > >
> > > > So any DT blob which incorrectly uses one of the other RGMII modes is
> > > > now going to break, where as before it was ignored.
> > >
> > > Potentially yes. There is a precedent with the at803x PHY driver
> >
> > Hi Florian
> >
> > Yes that was an interesting learning experience. I'm not sure we want
> > to do that again. A lot of devices broken, and a lot of people were
> > unhappy.
> >
> > If we are looking at a similar scale of breakage, i think i would
> > prefer to add a broadcom,bcm54210e-phy-mode property in the DT which
> > if present would override the phy_interface_t passed to the driver.
> >
> >    Andrew
> 
> What is the breakage concern here?

With the at803x, we had a lot of devices which said rgmii in there DT,
but actually needed rgmii-id. The driver however did not do anything,
and the silicon defaulted to rgmii-id, so things just worked, the two
bugs cancelling each other out.

Then a board come along which really did need rgmii. Adding support to
actually correctly configure the RGMII delays then broke all the
boards with the wrong value in DT.

> But in this case, the only breakage would be "hmmm, let's just enable
> RGMII delays everywhere. So it works with rgmii-id on both the PHY and
> the MAC side of things? Great, time for lunch!". I just hope that did
> not happen.

That is my hope as well. But letting it sit in net-next for a while
might help confirm that hope. As i said, at803x was painful, and i
would like to avoid that again. So i'm being more cautious.

      Andrew