netdev - Re: [patch net-next v3 01/15] netdevsim: change fib accounting and limitations to be per-device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191003160322.428bd9c0@cakuba.hsd1.ca.comcast.net>
Date:   Thu, 3 Oct 2019 16:03:22 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, idosch@...lanox.com,
        dsahern@...il.com, tariqt@...lanox.com, saeedm@...lanox.com,
        kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org, shuah@...nel.org,
        mlxsw@...lanox.com
Subject: Re: [patch net-next v3 01/15] netdevsim: change fib accounting and
 limitations to be per-device

On Thu,  3 Oct 2019 11:49:26 +0200, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...lanox.com>
> 
> Currently, the accounting is done per-namespace. However, devlink
> instance is always in init_net namespace for now, so only the accounting
> related to init_net is used. Limitations set using devlink resources
> are only considered for init_net. nsim_devlink_net() always
> returns init_net always.
> 
> Make the accounting per-device. This brings no functional change.
> Per-device accounting has the same values as per-net.
> For a single netdevsim instance, the behaviour is exactly the same
> as before. When multiple netdevsim instances are created, each
> can have different limits.
> 
> This is in prepare to implement proper devlink netns support. After
> that, the devlink instance which would exist in particular netns would
> account and limit that netns.
> 
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>