netdev - Re: [PATCH v2 net-next 2/2] net: dsa: mv88e6xxx: Add devlink param for ATU hash algorithm.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191004214043.GB12889@lunn.ch>
Date:   Fri, 4 Oct 2019 23:40:43 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH v2 net-next 2/2] net: dsa: mv88e6xxx: Add devlink param
 for ATU hash algorithm.

On Fri, Oct 04, 2019 at 02:32:36PM -0700, Jakub Kicinski wrote:
> On Fri,  4 Oct 2019 23:09:34 +0200, Andrew Lunn wrote:
> > diff --git a/Documentation/networking/devlink-params-mv88e6xxx.txt b/Documentation/networking/devlink-params-mv88e6xxx.txt
> > new file mode 100644
> > index 000000000000..cc5c1ac87c36
> > --- /dev/null
> > +++ b/Documentation/networking/devlink-params-mv88e6xxx.txt
> > @@ -0,0 +1,6 @@
> > +ATU_hash		[DEVICE, DRIVER-SPECIFIC]
> > +			Select one of four possible hashing algorithms for
> > +			MAC addresses in the Address Translation Unity.
> > +			A value of 3 seems to work better than the default of
> > +			1 when many MAC addresses have the same OUI.
> > +			Configuration mode: runtime
> 
> I think it's common practice to specify the type here? Otherwise looks
> good to me, thanks for adding it!

Hi Jakub

Ah, yes. It is a u8, but only values 0-3 are valid.

I will do a v3, but will wait a day for further comments.

    Andrew