netdev - Re: [v4 1/4] samples: pktgen: make variable consistent with option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEKGpzg_PGqkbUYi4Sdcm2WFxTXCQ61Mhu50kUfBtjYNhdne2A@mail.gmail.com>
Date:   Fri, 4 Oct 2019 22:46:47 +0900
From:   "Daniel T. Lee" <danieltimlee@...il.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     Toke Høiland-Jørgensen <toke@...hat.com>,
        "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [v4 1/4] samples: pktgen: make variable consistent with option

On Fri, Oct 4, 2019 at 10:41 PM Jesper Dangaard Brouer
<brouer@...hat.com> wrote:
>
> On Fri, 4 Oct 2019 22:28:26 +0900
> "Daniel T. Lee" <danieltimlee@...il.com> wrote:
>
> > On Fri, Oct 4, 2019 at 9:52 PM Jesper Dangaard Brouer <brouer@...hat.com> wrote:
> > >
> > >
> > > On Fri,  4 Oct 2019 10:32:58 +0900 "Daniel T. Lee" <danieltimlee@...il.com> wrote:
> > >
> > > > [...]
> > >
> >
> > Thanks for the review!
> >
> > > A general comment, you forgot a cover letter for your patchset.
> > >
> >
> > At first, I thought the size of the patchset (the feature to enhance)
> > was small so
> > I didn't include it with intent, but now it gets bigger and it seems
> > necessary for cover letter.
> >
> > When the next version is needed, I'll include it.
> >
> > > And also forgot the "PATCH" part of subj. but patchwork still found it:
> > > https://patchwork.ozlabs.org/project/netdev/list/?series=134102&state=2a
> > >
> >
> > I'm not sure I'm following.
> > Are you saying that the word "PATCH" should be included in prefix?
> >     $ git format-patch --subject-prefix="PATCH,v5"
> > like this?
>
> I would say "[PATCH net-next v5]" as you should also say which kernel
> tree, in this case net-next.
>
> All the rules are documented here:
>  https://www.kernel.org/doc/html/latest/process/index.html
>  https://www.kernel.org/doc/html/latest/process/submitting-patches.html
>
> This netdev list have it's own extra rules:
>  https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html
>

Thanks for the confirmation and letting me know.

I'll stick to it!

Thanks,
Daniel

> --
> Best regards,
>   Jesper Dangaard Brouer
>   MSc.CS, Principal Kernel Engineer at Red Hat
>   LinkedIn: http://www.linkedin.com/in/brouer