netdev - Re: [PATCH] r8152: Set macpassthru in reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191004.172759.987507160837677462.davem@davemloft.net>
Date:   Fri, 04 Oct 2019 17:27:59 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kai.heng.feng@...onical.com
Cc:     hayeswang@...ltek.com, mario.limonciello@...l.com,
        linux-usb@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] r8152: Set macpassthru in reset_resume callback

From: Kai-Heng Feng <kai.heng.feng@...onical.com>
Date: Fri,  4 Oct 2019 20:51:04 +0800

> r8152 may fail to establish network connection after resume from system
> suspend.
> 
> If the USB port connects to r8152 lost its power during system suspend,
> the MAC address was written before is lost. The reason is that The MAC
> address doesn't get written again in its reset_resume callback.
> 
> So let's set MAC address again in reset_resume callback. Also remove
> unnecessary lock as no other locking attempt will happen during
> reset_resume.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>

Applied.