netdev - RE: [PATCH bpf-next 01/10] bpf: add typecast to raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d99665856968_41932aacfa49e5b883@john-XPS-13-9370.notmuch>
Date:   Sat, 05 Oct 2019 20:58:16 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Alexei Starovoitov <ast@...nel.org>, davem@...emloft.net
Cc:     daniel@...earbox.net, x86@...nel.org, netdev@...r.kernel.org,
        bpf@...r.kernel.org, kernel-team@...com
Subject: RE: [PATCH bpf-next 01/10] bpf: add typecast to raw_tracepoints to
 help BTF generation

Alexei Starovoitov wrote:
> When pahole converts dwarf to btf it emits only used types.
> Wrap existing __bpf_trace_##template() function into
> btf_trace_##template typedef and use it in type cast to
> make gcc emits this type into dwarf. Then pahole will convert it to btf.
> The "btf_trace_" prefix will be used to identify BTF enabled raw tracepoints.
> 
> Signed-off-by: Alexei Starovoitov <ast@...nel.org>
> ---

FWIW I also have some cases where pahole gets padding wrong when
converting dwarf to btf on older kernels. I'll try to get some
more details and fix or get useful bug reports out next week.
For now I work around them with some code on my side but can
confuse tracing programs.

Acked-by: John Fastabend <john.fastabend@...il.com>