netdev - Re: [PATCH net-next 0/6] net/tls: minor micro optimizations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191007.155849.1777230056892941307.davem@davemloft.net>
Date:   Mon, 07 Oct 2019 15:58:49 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        davejwatson@...com, borisp@...lanox.com, aviadye@...lanox.com,
        john.fastabend@...il.com, daniel@...earbox.net
Subject: Re: [PATCH net-next 0/6] net/tls: minor micro optimizations

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Sun,  6 Oct 2019 21:09:26 -0700

> This set brings a number of minor code changes from my tree which
> don't have a noticeable impact on performance but seem reasonable
> nonetheless.
> 
> First sk_msg_sg copy array is converted to a bitmap, zeroing that
> structure takes a lot of time, hence we should try to keep it
> small.
> 
> Next two conditions are marked as unlikely, GCC seemed to had
> little trouble correctly reasoning about those.
> 
> Patch 4 adds parameters to tls_device_decrypted() to avoid
> walking structures, as all callers already have the relevant
> pointers.
> 
> Lastly two boolean members of TLS context structures are
> converted to a bitfield.

All looks good, series applied.