netdev - [PATCH net-next 0/6] net/tls: minor micro optimizations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191007040932.26395-1-jakub.kicinski@netronome.com>
Date:   Sun,  6 Oct 2019 21:09:26 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     davem@...emloft.net
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        davejwatson@...com, borisp@...lanox.com, aviadye@...lanox.com,
        john.fastabend@...il.com, daniel@...earbox.net,
        Jakub Kicinski <jakub.kicinski@...ronome.com>
Subject: [PATCH net-next 0/6] net/tls: minor micro optimizations

Hi!

This set brings a number of minor code changes from my tree which
don't have a noticeable impact on performance but seem reasonable
nonetheless.

First sk_msg_sg copy array is converted to a bitmap, zeroing that
structure takes a lot of time, hence we should try to keep it
small.

Next two conditions are marked as unlikely, GCC seemed to had
little trouble correctly reasoning about those.

Patch 4 adds parameters to tls_device_decrypted() to avoid
walking structures, as all callers already have the relevant
pointers.

Lastly two boolean members of TLS context structures are
converted to a bitfield.

Jakub Kicinski (6):
  net: sockmap: use bitmap for copy info
  net/tls: mark sk->err being set as unlikely
  net/tls: make allocation failure unlikely
  net/tls: pass context to tls_device_decrypted()
  net/tls: store async_capable on a single bit
  net/tls: store decrypted on a single bit

 include/linux/skmsg.h | 12 ++++++++----
 include/net/tls.h     | 13 ++++++++-----
 net/core/filter.c     |  4 ++--
 net/tls/tls_device.c  | 12 +++++-------
 net/tls/tls_sw.c      | 13 +++++++------
 5 files changed, 30 insertions(+), 24 deletions(-)

-- 
2.21.0