netdev - Re: [PATCH bpf-next] selftests/bpf: fix dependency ordering for attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 7 Oct 2019 10:36:21 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next] selftests/bpf: fix dependency ordering for
 attach_probe test

On Sun, Oct 6, 2019 at 10:29 PM Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
>
> On Sun, Oct 6, 2019 at 8:31 PM Andrii Nakryiko <andriin@...com> wrote:
> >
> > Current Makefile dependency chain is not strict enough and allows
> > test_attach_probe.o to be built before test_progs's
> > prog_test/attach_probe.o is built, which leads to assembler compainig
> > about missing included binary.
> >
> > This patch is a minimal fix to fix this issue by enforcing that
> > test_attach_probe.o (BPF object file) is built before
> > prog_tests/attach_probe.c is attempted to be compiled.
> >
> > Fixes: 928ca75e59d7 ("selftests/bpf: switch tests to new bpf_object__open_{file, mem}() APIs")
> > Signed-off-by: Andrii Nakryiko <andriin@...com>
>
> It doesn't help.
> Before and after I still see:
> $ cd selftests/bpf/
> $ make
> ...
> /tmp/cco8plDk.s: Assembler messages:
> /tmp/cco8plDk.s:8: Error: file not found: test_attach_probe.o

:( I'll try to come up with better fix then. Thanks for checking.