netdev - Re: i40e_pto.c: Odd use of strlcpy converted from strncpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c1d8f90b8a8bf97554f40aba85154088e5c1181c.camel@intel.com>
Date:   Mon, 07 Oct 2019 14:48:28 -0700
From:   Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:     Joe Perches <joe@...ches.com>, intel-wired-lan@...ts.osuosl.org,
        netdev <netdev@...r.kernel.org>
Cc:     Mitch Williams <mitch.a.williams@...el.com>,
        Patryk Małek <patryk.malek@...el.com>
Subject: Re: i40e_pto.c: Odd use of strlcpy converted from strncpy

On Mon, 2019-10-07 at 13:48 -0700, Joe Perches wrote:
> On Mon, 2019-10-07 at 13:44 -0700, Jeff Kirsher wrote:
> > On Sun, 2019-10-06 at 10:19 -0700, Joe Perches wrote:
> > > This got converted from strncpy to strlcpy but it's
> > > now not necessary to use one character less than the
> > > actual size.
> > > 
> > > Perhaps the sizeof() - 1 is now not correct and it
> > > should use strscpy and a normal sizeof.
> []
> > You are also missing you signed-off-by: and Fixes:, I can get your
> > change under test in the meantime to confirm your fix.
> 
> I didn't sign off as all I intended was to bring it
> to your attention.  The diff is just the simplest way.
> It's trivial if it's a defect.

Ah, thanks for bringing it to our attention.

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)