netdev - Re: [PATCH] ipv6: Make ipv6_mc_may

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191008122137.rgdmi2c7aixqx6lq@netronome.com>
Date:   Tue, 8 Oct 2019 14:21:39 +0200
From:   Simon Horman <simon.horman@...ronome.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] ipv6: Make ipv6_mc_may_pull() return bool.

On Mon, Oct 07, 2019 at 03:38:04PM +0200, David Miller wrote:
> 
> Consistent with how pskb_may_pull() also now does so.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>

Reviewed-by: Simon Horman <simon.horman@...ronome.com>

> ---
>  include/net/addrconf.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/net/addrconf.h b/include/net/addrconf.h
> index 3f62b347b04a..1bab88184d3c 100644
> --- a/include/net/addrconf.h
> +++ b/include/net/addrconf.h
> @@ -202,11 +202,11 @@ u32 ipv6_addr_label(struct net *net, const struct in6_addr *addr,
>  /*
>   *	multicast prototypes (mcast.c)
>   */
> -static inline int ipv6_mc_may_pull(struct sk_buff *skb,
> -				   unsigned int len)
> +static inline bool ipv6_mc_may_pull(struct sk_buff *skb,
> +				    unsigned int len)
>  {
>  	if (skb_transport_offset(skb) + ipv6_transport_len(skb) < len)
> -		return 0;
> +		return false;
>  
>  	return pskb_may_pull(skb, len);
>  }
> -- 
> 2.21.0
>