netdev - Re: [PATCH iproute2] Bareudp device support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191008090003.59a347eb@hermes.lan>
Date:   Tue, 8 Oct 2019 09:00:03 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Martin Varghese <martinvarghesenokia@...il.com>
Cc:     netdev@...r.kernel.org, scott.drennan@...ia.com, jbenc@...hat.com,
        martin.varghese@...ia.com
Subject: Re: [PATCH iproute2] Bareudp device support

On Tue,  8 Oct 2019 16:29:21 +0530
Martin Varghese <martinvarghesenokia@...il.com> wrote:

Overall ok, but where is man page?

> +
> +	if (tb[IFLA_BAREUDP_PORT])
> +		print_uint(PRINT_ANY,
> +				"port",
> +				"dstport %u ",
> +				rta_getattr_be16(tb[IFLA_BAREUDP_PORT]));

nit. these can be combined to be less lines.

> +	if (tb[IFLA_BAREUDP_EXTMODE]) {
> +		print_bool(PRINT_ANY, "extmode", "extmode ", true);
> +		return;
> +	}

One of the unwritten rules of ip commands is that the show format
should match the command line arguments.  In this case extmode is
really a presence flag not a boolean. best to print that with
json null command.

Also why the short circuit return.