netdev - Re: [PATCH bpf-next 06/10] bpf: add support for BTF pointers to interpreter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzYK3pm11EdhMJ+xgDbfVwFJ_Dnp6kgM839q5_AX+zc7sw@mail.gmail.com>
Date:   Mon, 7 Oct 2019 20:08:17 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Alexei Starovoitov <ast@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Daniel Borkmann <daniel@...earbox.net>, x86@...nel.org,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next 06/10] bpf: add support for BTF pointers to interpreter

On Fri, Oct 4, 2019 at 10:07 PM Alexei Starovoitov <ast@...nel.org> wrote:
>
> Pointer to BTF object is a pointer to kernel object or NULL.
> The memory access in the interpreter has to be done via probe_kernel_read
> to avoid page faults.
>
> Signed-off-by: Alexei Starovoitov <ast@...nel.org>
> ---

LGTM.

Acked-by: Andrii Nakryiko <andriin@...com>

>  include/linux/filter.h |  3 +++
>  kernel/bpf/core.c      | 19 +++++++++++++++++++
>  kernel/bpf/verifier.c  |  8 ++++++++
>  3 files changed, 30 insertions(+)
>

[...]