netdev - Re: [PATCH v3 bpf-next 5/7] libbpf: move bpf_{helpers,endian,tracing}.h into libbpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzbUVVThaLAwepit9V1voe7CBMPiK1rjkq-i-JXbFOnw2Q@mail.gmail.com>
Date:   Tue, 8 Oct 2019 11:02:16 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Jiri Benc <jbenc@...hat.com>
Cc:     Yonghong Song <yhs@...com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        David Ahern <dsahern@...il.com>,
        Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH v3 bpf-next 5/7] libbpf: move bpf_{helpers,endian,tracing}.h
 into libbpf

On Tue, Oct 8, 2019 at 8:37 AM Jiri Benc <jbenc@...hat.com> wrote:
>
> On Fri, 4 Oct 2019 18:37:44 +0000, Yonghong Song wrote:
> > distro can package bpf/btf uapi headers into libbpf package.
> > Users linking with libbpf.a/libbpf.so can use bpf/btf.h with include
> > path pointing to libbpf dev package include directory.
> > Could this work?
>
> I don't think it would. Distros have often a policy against bundling
> files that are available from one package (in this case, kernel-headers
> or similar) in a different package (libbpf).
>
> The correct way is making the libbpf package depend on a particular
> version of kernel-headers (or newer). As I said, I don't see a problem
> here. It's not a special situation, it's just usual dependencies.
>

We ended up switching to auto-generating BPF helpers from UAPI headers
w/ hardcoding BPF_FUNC_xxx values in bpf_helpers.h. So there is now no
dependency on any specific kernel version there.

>  Jiri