netdev - Re: [PATCH bpf-next v3 0/2] bpf/flow_dissector: add mode to enforce global BPF flow dissector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQLe+mrLo6oLwmQ8eeeNdomTXf-myq2kw=hyEbXFBJwYsA@mail.gmail.com>
Date:   Mon, 7 Oct 2019 20:21:17 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Stanislav Fomichev <sdf@...gle.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Petar Penkov <ppenkov@...gle.com>
Subject: Re: [PATCH bpf-next v3 0/2] bpf/flow_dissector: add mode to enforce
 global BPF flow dissector

On Mon, Oct 7, 2019 at 9:21 AM Stanislav Fomichev <sdf@...gle.com> wrote:
>
> While having a per-net-ns flow dissector programs is convenient for
> testing, security-wise it's better to have only one vetted global
> flow dissector implementation.
>
> Let's have a convention that when BPF flow dissector is installed
> in the root namespace, child namespaces can't override it.
>
> The intended use-case is to attach global BPF flow dissector
> early from the init scripts/systemd. Attaching global dissector
> is prohibited if some non-root namespace already has flow dissector
> attached. Also, attaching to non-root namespace is prohibited
> when there is flow dissector attached to the root namespace.
>
> v3:
> * drop extra check and empty line (Andrii Nakryiko)
>
> v2:
> * EPERM -> EEXIST (Song Liu)
> * Make sure we don't have dissector attached to non-root namespaces
>   when attaching the global one (Andrii Nakryiko)

Applied. Thanks