| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Oct 2019 23:16:51 -0700
From: Sridhar Samudrala <sridhar.samudrala@...el.com>
To: magnus.karlsson@...el.com, bjorn.topel@...el.com,
netdev@...r.kernel.org, bpf@...r.kernel.org,
sridhar.samudrala@...el.com, intel-wired-lan@...ts.osuosl.org,
maciej.fijalkowski@...el.com, tom.herbert@...el.com
Subject: [PATCH bpf-next 0/4] Enable direct receive on AF_XDP sockets
This is a rework of the following patch series
https://lore.kernel.org/netdev/1565840783-8269-1-git-send-email-sridhar.samudrala@intel.com/#r
that tried to enable direct receive by bypassing XDP program attached
to the device.
Based on the community feedback and some suggestions from Bjorn, changed
the semantics of the implementation to enable direct receive on AF_XDP
sockets that are bound to a queue only when there is no normal XDP program
attached to the device.
This is accomplished by introducing a special BPF prog pointer (DIRECT_XSK)
that is attached at the time of binding an AF_XDP socket to a queue of a
device. This is done only if there is no other XDP program attached to
the device. The normal XDP program has precedence and will replace the
DIRECT_XSK prog if it is attached later. The main reason to introduce a
special BPF prog pointer is to minimize the driver changes. The only change
is to use the bpf_get_prog_id() helper when QUERYING the prog id.
Any attach of a normal XDP program will take precedence and the direct xsk
program will be removed. The direct XSK program will be attached
automatically when the normal XDP program is removed when there are any
AF_XDP direct sockets associated with that device.
A static key is used to control this feature in order to avoid any overhead
for normal XDP datapath when there are no AF_XDP sockets in direct-xsk mode.
Here is some performance data i collected on my Intel Ivybridge based
development system (Intel(R) Xeon(R) CPU E5-2697 v2 @ 2.70GHz)
NIC: Intel 40Gb ethernet (i40e)
xdpsock rxdrop 1 core (both app and queue's irq pinned to the same core)
default : taskset -c 1 ./xdpsock -i enp66s0f0 -r -q 1
direct-xsk :taskset -c 1 ./xdpsock -i enp66s0f0 -r -q 1
6.1x improvement in drop rate
xdpsock rxdrop 2 core (app and queue's irq pinned to different cores)
default : taskset -c 3 ./xdpsock -i enp66s0f0 -r -q 1
direct-xsk :taskset -c 3 ./xdpsock -i enp66s0f0 -r -d -q 1
6x improvement in drop rate
xdpsock l2fwd 1 core (both app and queue's irq pinned to the same core)
default : taskset -c 1 ./xdpsock -i enp66s0f0 -l -q 1
direct-xsk :taskset -c 1 ./xdpsock -i enp66s0f0 -l -d -q 1
3.5x improvement in l2fwd rate
xdpsock rxdrop 2 core (app and queue'sirq pinned to different cores)
default : taskset -c 3 ./xdpsock -i enp66s0f0 -l -q 1
direct-xsk :taskset -c 3 ./xdpsock -i enp66s0f0 -l -d -q 1
4.5x improvement in l2fwd rate
dpdk-pktgen is used to send 64byte UDP packets from a link partner and
ethtool ntuple flow rule is used to redirect packets to queue 1 on the
system under test.
Sridhar Samudrala (4):
bpf: introduce bpf_get_prog_id and bpf_set_prog_id helper functions.
xsk: allow AF_XDP sockets to receive packets directly from a queue
libbpf: handle AF_XDP sockets created with XDP_DIRECT bind flag.
xdpsock: add an option to create AF_XDP sockets in XDP_DIRECT mode
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 2 +-
drivers/net/ethernet/cavium/thunder/nicvf_main.c | 2 +-
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 +-
drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +-
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 +-
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 3 +-
drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 3 +-
drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 3 +-
drivers/net/ethernet/qlogic/qede/qede_filter.c | 2 +-
drivers/net/ethernet/socionext/netsec.c | 2 +-
drivers/net/netdevsim/bpf.c | 6 ++-
drivers/net/tun.c | 4 +-
drivers/net/veth.c | 4 +-
drivers/net/virtio_net.c | 3 +-
include/linux/bpf.h | 3 ++
include/linux/filter.h | 18 +++++++
include/linux/netdevice.h | 10 ++++
include/net/xdp_sock.h | 5 ++
include/trace/events/xdp.h | 4 +-
include/uapi/linux/if_xdp.h | 5 ++
kernel/bpf/arraymap.c | 2 +-
kernel/bpf/cgroup.c | 2 +-
kernel/bpf/core.c | 2 +-
kernel/bpf/syscall.c | 33 +++++++++----
kernel/events/core.c | 2 +-
kernel/trace/bpf_trace.c | 2 +-
net/core/dev.c | 54 ++++++++++++++++++++-
net/core/filter.c | 58 +++++++++++++++++++++++
net/core/flow_dissector.c | 2 +-
net/core/rtnetlink.c | 2 +-
net/core/xdp.c | 2 +-
net/ipv6/seg6_local.c | 2 +-
net/sched/act_bpf.c | 2 +-
net/sched/cls_bpf.c | 2 +-
net/xdp/xsk.c | 51 +++++++++++++++++++-
samples/bpf/xdpsock_user.c | 17 +++++--
tools/include/uapi/linux/if_xdp.h | 5 ++
tools/lib/bpf/xsk.c | 6 +++
38 files changed, 279 insertions(+), 53 deletions(-)
--
2.14.5
Powered by blists - more mailing lists