lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 8 Oct 2019 09:29:58 +0100 (BST)
From:   "Maciej W. Rozycki" <macro@...ux-mips.org>
To:     Colin King <colin.king@...onical.com>
cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] netdevsim: fix spelling mistake "forbidded" ->
 "forbid"

On Tue, 8 Oct 2019, Colin King wrote:

> diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
> index a3d7d39f231a..ff6ced5487b6 100644
> --- a/drivers/net/netdevsim/dev.c
> +++ b/drivers/net/netdevsim/dev.c
> @@ -486,7 +486,7 @@ static int nsim_dev_reload_down(struct devlink *devlink, bool netns_change,
>  		/* For testing purposes, user set debugfs dont_allow_reload
>  		 * value to true. So forbid it.
>  		 */
> -		NL_SET_ERR_MSG_MOD(extack, "User forbidded reload for testing purposes");
> +		NL_SET_ERR_MSG_MOD(extack, "User forbid the reload for testing purposes");

 If nitpicking about grammar, then FWIW I believe it should actually be:

		NL_SET_ERR_MSG_MOD(extack, "User forbade the reload for testing purposes");

(and then:

		NL_SET_ERR_MSG_MOD(extack, "User set up the reload to fail for testing purposes");

elsewhere).

  Maciej

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ