netdev - Re: [patch iproute2-next v2 1/2] ip: add support for alternative name addition/deletion/list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191009111339.GH2326@nanopsycho>
Date:   Wed, 9 Oct 2019 13:13:39 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     David Ahern <dsahern@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        jakub.kicinski@...ronome.com, roopa@...ulusnetworks.com,
        dcbw@...hat.com, nikolay@...ulusnetworks.com, mkubecek@...e.cz,
        andrew@...n.ch, parav@...lanox.com, saeedm@...lanox.com,
        f.fainelli@...il.com, stephen@...workplumber.org,
        sd@...asysnail.net, sbrivio@...hat.com, pabeni@...hat.com,
        mlxsw@...lanox.com
Subject: Re: [patch iproute2-next v2 1/2] ip: add support for alternative
 name addition/deletion/list

Mon, Oct 07, 2019 at 11:37:21PM CEST, dsahern@...il.com wrote:
>On 10/2/19 4:56 AM, Jiri Pirko wrote:
>> diff --git a/ip/iplink.c b/ip/iplink.c
>> index 212a088535da..e3f8a28fe94c 100644
>> --- a/ip/iplink.c
>> +++ b/ip/iplink.c
>> @@ -111,7 +111,9 @@ void iplink_usage(void)
>>  		"\n"
>>  		"	ip link xstats type TYPE [ ARGS ]\n"
>>  		"\n"
>> -		"	ip link afstats [ dev DEVICE ]\n");
>> +		"	ip link afstats [ dev DEVICE ]\n"
>> +		"	ip link prop add dev DEVICE [ altname NAME .. ]\n"
>> +		"	ip link prop del dev DEVICE [ altname NAME .. ]\n");
>
>spell out 'property' here. The matches below on "prop" is fine, but the
>help can show the full name.

Okay.


>
>
>> +
>> +	if (matches(*argv, "add") == 0) {
>> +		req.n.nlmsg_flags |= NLM_F_EXCL | NLM_F_CREATE | NLM_F_APPEND;
>> +		req.n.nlmsg_type = RTM_NEWLINKPROP;
>> +	} else if (matches(*argv, "del") == 0) {
>> +		req.n.nlmsg_flags |= RTM_DELLINK;
>
>RTM_DELLINK is a command not a netlink flag.

Will fix.