netdev - Re: [PATCH RESEND] rtlwifi: rtl8192ee: Remove set but not used variable 'err'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9c16275-16bc-25d0-9761-abcb0e47b2f4@huawei.com>
Date:   Wed, 9 Oct 2019 21:06:53 +0800
From:   "zhengbin (A)" <zhengbin13@...wei.com>
To:     Kalle Valo <kvalo@...eaurora.org>
CC:     <pkshih@...ltek.com>, <linux-wireless@...r.kernel.org>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH RESEND] rtlwifi: rtl8192ee: Remove set but not used
 variable 'err'


On 2019/10/9 21:05, Kalle Valo wrote:
> "zhengbin (A)" <zhengbin13@...wei.com> writes:
>
>> On 2019/10/9 20:58, Kalle Valo wrote:
>>> zhengbin <zhengbin13@...wei.com> writes:
>>>
>>>> Fixes gcc '-Wunused-but-set-variable' warning:
>>>>
>>>> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c: In function rtl92ee_download_fw:
>>>> drivers/net/wireless/realtek/rtlwifi/rtl8192ee/fw.c:111:6: warning:
>>>> variable err set but not used [-Wunused-but-set-variable]
>>>>
>>>> Reported-by: Hulk Robot <hulkci@...wei.com>
>>>> Signed-off-by: zhengbin <zhengbin13@...wei.com>
>>>> Acked-by: Ping-Ke Shih <pkshih@...ltek.com>
>>> There's no changelog, why did you resend? Document clearly the changes
>>> so that maintainers don't need to guess what has changed:
>> Failed to apply:
>>
>> fatal: corrupt patch at line 13
>> error: could not build fake ancestor
>> Applying: rtlwifi: rtl8192ee: Remove set but not used variable 'err'
>> Patch failed at 0001 rtlwifi: rtl8192ee: Remove set but not used variable 'err'
>> The copy of the patch that failed is found in: .git/rebase-apply/patch
>>
>> So I resend this. 
> Ok, thanks. But next time include the changelog automatically and mark
> the patch as v2. And read the documentation:
Copy that, thank your for your patience
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>